Skip to content

CFBM: Refinements in the level set - #2361

Merged
weiwangncar merged 2 commits into
wrf-model:release-v4.8.1from
pedro-jm:cfbm_fix
Sep 3, 2026
Merged

CFBM: Refinements in the level set#2361
weiwangncar merged 2 commits into
wrf-model:release-v4.8.1from
pedro-jm:cfbm_fix

Conversation

@pedro-jm

@pedro-jm pedro-jm commented Jun 29, 2026 •
edited by weiwangncar
Loading

Copy link
Copy Markdown
Contributor

TYPE: bug fix

KEYWORDS: CFBM, fire propagation, default settings

SOURCE: Pedro A. Jimenez (NCAR)

DESCRIPTION OF CHANGES:
Problem:
There are instabilities in the methods used to determine the fire propagation

Solution:

  1. We updated the default value of a namelist variable, the pseudo time step coefficient for the level set reinitialization
  2. We use the previous ENO method to solve the level set equation

LIST OF MODIFIED FILES: We only updated the hash of the fire_behavior git submodule

TESTS CONDUCTED:
The Jenkins tests are all passing.

RELEASE NOTE: This PR refined methods for the fire propagation in the CFBM.

@pedro-jm
pedro-jm requested a review from a team as a code owner June 29, 2026 22:20
@weiwangncar
weiwangncar changed the base branch from develop to release-v4.8.1 July 27, 2026 19:43
@dudhia

dudhia commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

This PR seems to have failed the tests. @weiwangncar can you check?

@weiwangncar

weiwangncar commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

@dudhia I did not receive any test results. I started a re-test and see if it goes anywhere.

@weiwangncar

weiwangncar commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

The regression test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

@weiwangncar
weiwangncar merged commit 71bf0e9 into wrf-model:release-v4.8.1 Sep 3, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weiwangncar weiwangncar weiwangncar approved these changes
@dudhia dudhia dudhia approved these changes

Assignees

No one assigned

Labels

release-v4.8.1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pedro-jm @dudhia @weiwangncar